From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Wed, 15 Apr 2009 15:54:19 +0000 (+0100)
Subject: gitk: Handle external diff tool with spaces in the path
X-Git-Url: https://privyetmir.co.uk/gitweb.cgi?a=commitdiff_plain;h=b575b2f1f420bf82557beab0f4ec12e5aa832bea;p=gitk

gitk: Handle external diff tool with spaces in the path

This fixes the launching of external diff to handle a diff tool
that has spaces in the path.  This ensures a correctly formed
tcl list is passed to the open command with a single pipe character
prefixing the list (as per the tcl manual page for open).

The specific fault observed was that selecting WinMerge as the diff
tool from the default installed location in Program Files failed to
be launched from the context menu.

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index 045e4ab..488286f 100755
--- a/gitk
+++ b/gitk
@@ -3245,9 +3245,8 @@ proc external_diff {} {
     set difftofile [external_diff_get_one_file $diffidto $flist_menu_file $diffdir]
 
     if {$difffromfile ne {} && $difftofile ne {}} {
-        set cmd [concat | [shellsplit $extdifftool] \
-		     [list $difffromfile $difftofile]]
-        if {[catch {set fl [open $cmd r]} err]} {
+        set cmd [list [shellsplit $extdifftool] $difffromfile $difftofile]
+        if {[catch {set fl [open |$cmd r]} err]} {
             file delete -force $diffdir
             error_popup "$extdifftool: [mc "command failed:"] $err"
         } else {